Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use common Hiero Gradle config #216

Merged
merged 18 commits into from
Jan 9, 2025
Merged

build: use common Hiero Gradle config #216

merged 18 commits into from
Jan 9, 2025

Conversation

jjohannes
Copy link
Contributor

@jjohannes jjohannes commented Sep 26, 2024 •
edited
Loading

Description:

Before this can be integrated:

  • Publish hiero-gradle-conventions plugins to Gradle Plugin Portal and use from there

Related issue(s):

hashgraph/hedera-services#14255

@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 7714646 to 222c26c Compare October 8, 2024 07:35
@jjohannes jjohannes self-assigned this Oct 8, 2024
@jjohannes jjohannes added the P3 Low priority issue. Will not impact the release schedule if not complete. label Oct 8, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 3 times, most recently from ca2a5a2 to ffd5207 Compare October 8, 2024 09:46
@jjohannes jjohannes mentioned this pull request Oct 8, 2024
Closed
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 5 times, most recently from e91163b to a6fa9da Compare October 16, 2024 07:06
@jjohannes jjohannes changed the title build: use common Hedera Gradle config build: use common Hiero Gradle config Nov 4, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from a6fa9da to 84eb4d2 Compare November 4, 2024 15:22
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 3 times, most recently from e2d53b8 to 17a484d Compare December 11, 2024 14:30
jjohannes
jjohannes commented Dec 11, 2024
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
@jjohannes jjohannes added this to the 0.4.0 milestone Dec 11, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 17a484d to 1126d25 Compare December 11, 2024 14:48
@jjohannes jjohannes marked this pull request as ready for review December 11, 2024 14:56
@jjohannes jjohannes requested review from a team as code owners December 11, 2024 14:56
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 1126d25 to 65f8772 Compare December 11, 2024 14:59
jjohannes added 10 commits January 9, 2025 08:10
@jjohannes
build: re-add 'tools' project
ef12288 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
build: use dependency notation baed on Module Names
9ca7fcc 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
build: update Gradle
3d4e426 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
build: re-activate dependency scope check in 'tools'
33eebf8 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
build: streamline tools/build.gradle.kts
5f390f3 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
build: consistently use Module Name dependency notation
73ab847 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
chore: revert unnecessary changes to comments
8845b23 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
chore: remove confusing comment
43f4595 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
build: consistent plugin declartions
b0a54ee 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes
Merge branch 'main' into 14255-reusable-gradle-config
71815bb
@jjohannes jjohannes modified the milestones: 0.4.0, 0.3.0 Jan 9, 2025
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 8d17ba4 to ff2d2bc Compare January 9, 2025 08:37
@jjohannes
chore: remove superfluous comments
c62dabf 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from ff2d2bc to c62dabf Compare January 9, 2025 08:38
ata-nas
ata-nas reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjohannes LG. A couple of nits/questions.

Just recently, a migration to SPDX license headers happened. Maybe some headers were missed, I am unsure which or if all files are eligible to have this header. Please feel free to proactively resolve my comments if files, where I have left a comment for the header, should not actually have the header. (My comments are mostly to bring attention in case some headers might be missed)

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
gradle/toolchain-versions.properties Show resolved Hide resolved
gradle/toolchain-versions.properties Show resolved Hide resolved
simulator/src/main/java/module-info.java Outdated Show resolved Hide resolved
stream/src/main/java/module-info.java Outdated Show resolved Hide resolved
suites/build.gradle.kts Outdated Show resolved Hide resolved
suites/src/main/java/module-info.java Outdated Show resolved Hide resolved
version.txt Outdated Show resolved Hide resolved
@jjohannes jjohannes mentioned this pull request Jan 9, 2025
Closed
@jjohannes
Copy link
Contributor Author

Thanks @ata-nas. Addressed the comments and/or answered. Note that the headers I added manually now will also be handled by spotlessApply in the near future. Related:

@jjohannes
chore: add license headers
f2bc04f 
Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 4f361ca to f2bc04f Compare January 9, 2025 12:33
ata-nas
ata-nas approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjohannes looks good! Before merging please see also if others have other comments (I remember people asked in the near past to wait with merging this for a bit, since they needed to change things which would conflict with this, I am not sure if everybody is ready) @AlfredoG87 @mattp-swirldslabs @jsync-swirlds @georgi-l95 @jasperpotts tag for awareness.

jsync-swirlds
jsync-swirlds reviewed Jan 9, 2025
View reviewed changes
gradlew Show resolved Hide resolved
andrewb1269hg
andrewb1269hg approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve following files:
.github/dependabot.yml
.github/workflows/pr-checks.yaml

@jjohannes jjohannes merged commit 332b9a6 into main Jan 9, 2025
11 checks passed
@jjohannes jjohannes deleted the 14255-reusable-gradle-config branch January 9, 2025 18:06
@jjohannes jjohannes mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsync-swirlds jsync-swirlds jsync-swirlds left review comments

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs left review comments

@andrewb1269hg andrewb1269hg andrewb1269hg approved these changes

@ata-nas ata-nas ata-nas approved these changes

@mishomihov00 mishomihov00 mishomihov00 left review comments

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL

Assignees

@jjohannes jjohannes

Labels
P3 Low priority issue. Will not impact the release schedule if not complete.
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
8 participants
@jjohannes @ata-nas @mattp-swirldslabs @jsync-swirlds @AlfredoG87 @rbarkerSL @andrewb1269hg @mishomihov00